add type check to conf_encoding (in thoery could be bool or int)

Author: Yobmod

git/cmd.py

@@ -109,18 +109,16 @@ def pump_stream(cmdline: List[str], name: str, stream: Union[BinaryIO, TextIO],
                     else:
                         handler(line)
         except Exception as ex:
-            log.error(f"Pumping {name!r} of cmd({remove_password_if_present(cmdline)})} failed due to: {ex!r}")
+            log.error(f"Pumping {name!r} of cmd({remove_password_if_present(cmdline)}) failed due to: {ex!r}")
             raise CommandError([f'<{name}-pump>'] + remove_password_if_present(cmdline), ex) from ex
         finally:
             stream.close()
 
-
-
     if hasattr(process, 'proc'):
         process = cast('Git.AutoInterrupt', process)
         cmdline: str | Tuple[str, ...] | List[str] = getattr(process.proc, 'args', '')
-        p_stdout = process.proc.stdout
-        p_stderr = process.proc.stderr
+        p_stdout = process.proc.stdout if process.proc else None
+        p_stderr = process.proc.stderr if process.proc else None
     else:
         process = cast(Popen, process)
         cmdline = getattr(process, 'args', '')

git/config.py

@@ -31,7 +31,7 @@
 # typing-------------------------------------------------------
 
 from typing import (Any, Callable, Generic, IO, List, Dict, Sequence,
-                    TYPE_CHECKING, Tuple, TypeVar, Union, cast, overload)
+                    TYPE_CHECKING, Tuple, TypeVar, Union, cast)
 
 from git.types import Lit_config_levels, ConfigLevels_Tup, PathLike, assert_never, _T
 
@@ -709,15 +709,6 @@ def read_only(self) -> bool:
         """:return: True if this instance may change the configuration file"""
         return self._read_only
 
-    @overload
-    def get_value(self, section: str, option: str, default: None = None) -> Union[int, float, str, bool]: ...
-
-    @overload
-    def get_value(self, section: str, option: str, default: str) -> str: ...
-
-    @overload
-    def get_value(self, section: str, option: str, default: float) -> float: ...
-
     def get_value(self, section: str, option: str, default: Union[int, float, str, bool, None] = None
                   ) -> Union[int, float, str, bool]:
         # can default or return type include bool?

git/objects/commit.py

@@ -446,6 +446,8 @@ def create_from_tree(cls, repo: 'Repo', tree: Union[Tree, str], message: str,
         # assume utf8 encoding
         enc_section, enc_option = cls.conf_encoding.split('.')
         conf_encoding = cr.get_value(enc_section, enc_option, cls.default_encoding)
+        if not isinstance(conf_encoding, str):
+            raise TypeError("conf_encoding could not be coerced to str")
 
         # if the tree is no object, make sure we create one - otherwise
         # the created commit object is invalid