ensure that bridge is not destroyed when semantics is still enabled (#5672)

Jonah Williams · web-flow · commit 5724faf86ec9 · 2018-07-03T22:25:40.000-07:00
diff --git a/shell/platform/darwin/ios/platform_view_ios.mm b/shell/platform/darwin/ios/platform_view_ios.mm
@@ -65,7 +65,7 @@
 void PlatformViewIOS::SetSemanticsEnabled(bool enabled) {
   if (enabled && !accessibility_bridge_) {
     accessibility_bridge_ = std::make_unique<AccessibilityBridge>(owner_view_, this);
-  } else {
+  } else if (!enabled && accessibility_bridge_) {
     accessibility_bridge_.reset();
   }
   PlatformView::SetSemanticsEnabled(enabled);

Original file line number	Diff line number	Diff line change
`@@ -65,7 +65,7 @@`
`65`	`65`	`void PlatformViewIOS::SetSemanticsEnabled(bool enabled) {`
`66`	`66`	`if (enabled && !accessibility_bridge_) {`
`67`	`67`	`accessibility_bridge_ = std::make_unique<AccessibilityBridge>(owner_view_, this);`
`68`		`- } else {`
	`68`	`+ } else if (!enabled && accessibility_bridge_) {`
`69`	`69`	`accessibility_bridge_.reset();`
`70`	`70`	`}`
`71`	`71`	`PlatformView::SetSemanticsEnabled(enabled);`