This repository was archived by the owner on Oct 19, 2023. It is now read-only.
Auto-require and register partials (+tests)#47
Merged
kirbysayshi merged 3 commits intoesamattis:masterfrom Sep 9, 2015
Merged
Conversation
Collaborator
Author
|
Just noticed the build failed. Looks like the travis config is out of date since it's using a very old npm and node. |
Collaborator
Author
|
@epeli Heyo, just checking in. Do you think you'll have time to take a look at this PR any time soon? |
kirbysayshi
added a commit
that referenced
this pull request
Sep 9, 2015
Auto-require and register partials (+tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello! This PR adds support for implicit
requireof Handlebars partials. This way you can do something like:And it will automatically be
requireed by browserify and then registered as a partial.Since this is a large-ish change, I completely understand if you don't want to merge this / maintain this functionality. If so, just let me know! I'll probably do some sort of hard fork (with a completely different name, of course). If you are into it, let me know and I'll add some documentation :) And of course, please let me know your general thoughts as well.
Thanks!