Skip to content

Replace relative imports to make isort happy #681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2019
Merged

Replace relative imports to make isort happy #681

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
93a0917
Fix isort issue.
amw Aug 6, 2019
00ac7c3
Replace relative imports
sliverc Aug 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replace relative imports
  • Loading branch information
@sliverc
sliverc committed Aug 15, 2019
commit 00ac7c3e68c2e774f58c93e93932f84f73bda389
4 changes: 2 additions & 2 deletions example/api/resources/identity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@

from rest_framework_json_api import utils

from ..serializers.identity import IdentitySerializer
from ..serializers.post import PostSerializer
from example.api.serializers.identity import IdentitySerializer
from example.api.serializers.post import PostSerializer


class Identity(viewsets.ModelViewSet):
Expand Down
2 changes: 1 addition & 1 deletion example/tests/test_filters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
from rest_framework.reverse import reverse
from rest_framework.test import APITestCase

from ..models import Blog, Entry
from example.models import Blog, Entry


class DJATestFilters(APITestCase):
Expand Down
4 changes: 2 additions & 2 deletions example/tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"""
from rest_framework_json_api import utils

from ..serializers import AuthorSerializer, EntrySerializer
from ..tests import TestBase
from example.serializers import AuthorSerializer, EntrySerializer
from example.tests import TestBase


class GetRelatedResourceTests(TestBase):
Expand Down
11 changes: 5 additions & 6 deletions example/tests/test_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,11 @@

from rest_framework_json_api.utils import format_resource_type

from . import TestBase
from .. import views
from example.factories import AuthorFactory, CommentFactory, EntryFactory
from example.models import Author, Blog, Comment, Entry
from example.serializers import AuthorBioSerializer, AuthorTypeSerializer, EntrySerializer
from example.views import AuthorViewSet
from example.tests import TestBase
from example.views import AuthorViewSet, BlogViewSet


class TestRelationshipView(APITestCase):
Expand Down Expand Up @@ -427,7 +426,7 @@ def test_retrieve_related_None(self):

class TestValidationErrorResponses(TestBase):
def test_if_returns_error_on_empty_post(self):
view = views.BlogViewSet.as_view({'post': 'create'})
view = BlogViewSet.as_view({'post': 'create'})
response = self._get_create_response("{}", view)
self.assertEqual(400, response.status_code)
expected = [{
Expand All @@ -438,7 +437,7 @@ def test_if_returns_error_on_empty_post(self):
self.assertEqual(expected, response.data)

def test_if_returns_error_on_missing_form_data_post(self):
view = views.BlogViewSet.as_view({'post': 'create'})
view = BlogViewSet.as_view({'post': 'create'})
response = self._get_create_response('{"data":{"attributes":{},"type":"blogs"}}', view)
self.assertEqual(400, response.status_code)
expected = [{
Expand All @@ -449,7 +448,7 @@ def test_if_returns_error_on_missing_form_data_post(self):
self.assertEqual(expected, response.data)

def test_if_returns_error_on_bad_endpoint_name(self):
view = views.BlogViewSet.as_view({'post': 'create'})
view = BlogViewSet.as_view({'post': 'create'})
response = self._get_create_response('{"data":{"attributes":{},"type":"bad"}}', view)
self.assertEqual(409, response.status_code)
expected = [{
Expand Down