Merge pull request #870 from sliverc/do_not_ignore_f405

Do not ignore F405 linting error

Author: n2ygk

example/settings/test.py

@@ -13,7 +13,7 @@
 JSON_API_FORMAT_TYPES = "camelize"
 JSON_API_PLURALIZE_TYPES = True
 
-REST_FRAMEWORK.update(
+REST_FRAMEWORK.update(  # noqa: F405
     {  # noqa
         "PAGE_SIZE": 1,
     }

rest_framework_json_api/serializers.py

@@ -1,9 +1,22 @@
+from collections import OrderedDict
+
 import inflection
 from django.core.exceptions import ObjectDoesNotExist
 from django.db.models.query import QuerySet
 from django.utils.translation import gettext_lazy as _
 from rest_framework.exceptions import ParseError
-from rest_framework.serializers import *  # noqa: F403
+
+# star import defined so `rest_framework_json_api.serializers` can be
+# a simple drop in for `rest_framework.serializers`
+from rest_framework.serializers import *  # noqa: F401, F403
+from rest_framework.serializers import (
+    BaseSerializer,
+    HyperlinkedModelSerializer,
+    ModelSerializer,
+    Serializer,
+    SerializerMetaclass,
+)
+from rest_framework.settings import api_settings
 
 from rest_framework_json_api.exceptions import Conflict
 from rest_framework_json_api.relations import ResourceRelatedField

setup.cfg

@@ -10,10 +10,7 @@ extend-ignore =
     # whitespace before ':' - disabled as not PEP8 compliant
     E203,
     # line too long (managed by black)
-    E501,
-    # usage of star imports
-    # TODO mark star imports directly in code to ignore this error
-    F405
+    E501
 exclude =
     build/lib,
     .eggs