Skip to content

Commit c863a3d

Browse files
committed
Removed obsolete import_string call for related serializers
1 parent 6850419 commit c863a3d

File tree

2 files changed

+1
-11
lines changed

2 files changed

+1
-11
lines changed

rest_framework_json_api/schemas/openapi.py

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
import warnings
22
from urllib.parse import urljoin
33

4-
from django.utils.module_loading import import_string as import_class_from_dotted_path
54
from rest_framework.fields import empty
65
from rest_framework.relations import ManyRelatedField
76
from rest_framework.schemas import openapi as drf_openapi
@@ -379,13 +378,7 @@ def _find_related_view(self, view_endpoints, related_serializer, parent_view):
379378
"""
380379
for path, method, view in view_endpoints:
381380
view_serializer = view.get_serializer()
382-
if not isinstance(related_serializer, type):
383-
related_serializer_class = import_class_from_dotted_path(
384-
related_serializer
385-
)
386-
else:
387-
related_serializer_class = related_serializer
388-
if isinstance(view_serializer, related_serializer_class):
381+
if isinstance(view_serializer, related_serializer):
389382
return view
390383

391384
return None

rest_framework_json_api/views.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@
1111
from django.db.models.manager import Manager
1212
from django.db.models.query import QuerySet
1313
from django.urls import NoReverseMatch
14-
from django.utils.module_loading import import_string as import_class_from_dotted_path
1514
from rest_framework import generics, viewsets
1615
from rest_framework.exceptions import MethodNotAllowed, NotFound
1716
from rest_framework.fields import get_attribute
@@ -183,8 +182,6 @@ def get_related_serializer_class(self):
183182
False
184183
), 'Either "included_serializers" or "related_serializers" should be configured'
185184

186-
if not isinstance(_class, type):
187-
return import_class_from_dotted_path(_class)
188185
return _class
189186

190187
return parent_serializer_class

0 commit comments

Comments
 (0)