Ensured that sparse fieldset support formatted field names (#1286)

Author: sliverc

CHANGELOG.md

@@ -19,6 +19,7 @@ any parts of the framework not mentioned in the documentation should generally b
 
 * Ensured that interpreting `include` query parameter is done in internal Python naming.
   This adds full support for using multipart field names for includes while configuring `JSON_API_FORMAT_FIELD_NAMES`.
+* Ensured that sparse fieldset fully supports `JSON_API_FORMAT_FIELD_NAMES`.
 
 ### Removed
 

rest_framework_json_api/serializers.py

@@ -26,6 +26,7 @@
     get_resource_type_from_instance,
     get_resource_type_from_model,
     get_resource_type_from_serializer,
+    undo_format_field_name,
 )
 
 
@@ -89,7 +90,10 @@ def _readable_fields(self):
                     sparse_fieldset_query_param
                 )
                 if sparse_fieldset_value is not None:
-                    sparse_fields = sparse_fieldset_value.split(",")
+                    sparse_fields = [
+                        undo_format_field_name(sparse_field)
+                        for sparse_field in sparse_fieldset_value.split(",")
+                    ]
                     return (
                         field
                         for field in readable_fields

tests/test_serializers.py

@@ -1,5 +1,6 @@
 import pytest
 from django.db import models
+from rest_framework.request import Request
 from rest_framework.utils import model_meta
 
 from rest_framework_json_api import serializers
@@ -84,3 +85,22 @@ class Meta:
         "verified",
         "uuid",
     ]
+
+
+def test_readable_fields_with_sparse_fields(client, rf, settings):
+    class TestSerializer(serializers.Serializer):
+        name = serializers.CharField()
+        value = serializers.CharField()
+        multi_part_name = serializers.CharField()
+
+        class Meta:
+            resource_name = "test"
+
+    settings.JSON_API_FORMAT_FIELD_NAMES = "camelize"
+    request = Request(rf.get("/test/", {"fields[test]": "value,multiPartName"}))
+    context = {"request": request}
+    serializer = TestSerializer(context=context)
+    assert [field.field_name for field in serializer._readable_fields] == [
+        "value",
+        "multi_part_name",
+    ]