Fixed almost all the problem reported by golint

Author: Mattia Bertorello

arduino/cores/packagemanager/package_manager.go

@@ -162,7 +162,7 @@ func (pm *PackageManager) ResolveFQBN(fqbn *cores.FQBN) (
 	platformRelease := platform.GetInstalled()
 	if platformRelease == nil {
 		return targetPackage, nil, nil, nil, nil,
-			fmt.Errorf("Platform %s is not installed", platformRelease)
+			fmt.Errorf("platform %s is not installed", platformRelease)
 	}
 
 	// Find board
@@ -210,31 +210,31 @@ func (pm *PackageManager) LoadPackageIndex(URL *url.URL) error {
 
 // Package looks for the Package with the given name, returning a structure
 // able to perform further operations on that given resource
-func (pm *PackageManager) Package(name string) *packageActions {
+func (pm *PackageManager) Package(name string) *PackageActions {
 	//TODO: perhaps these 2 structure should be merged? cores.Packages vs pkgmgr??
 	var err error
 	thePackage := pm.packages.Packages[name]
 	if thePackage == nil {
 		err = fmt.Errorf("package '%s' not found", name)
 	}
-	return &packageActions{
+	return &PackageActions{
 		aPackage:     thePackage,
 		forwardError: err,
 	}
 }
 
 // Actions that can be done on a Package
 
-// packageActions defines what actions can be performed on the specific Package
+// PackageActions defines what actions can be performed on the specific Package
 // It serves as a status container for the fluent APIs
-type packageActions struct {
+type PackageActions struct {
 	aPackage     *cores.Package
 	forwardError error
 }
 
 // Tool looks for the Tool with the given name, returning a structure
 // able to perform further operations on that given resource
-func (pa *packageActions) Tool(name string) *toolActions {
+func (pa *PackageActions) Tool(name string) *ToolActions {
 	var tool *cores.Tool
 	err := pa.forwardError
 	if err == nil {
@@ -244,7 +244,7 @@ func (pa *packageActions) Tool(name string) *toolActions {
 			err = fmt.Errorf("tool '%s' not found in package '%s'", name, pa.aPackage.Name)
 		}
 	}
-	return &toolActions{
+	return &ToolActions{
 		tool:         tool,
 		forwardError: err,
 	}
@@ -254,15 +254,15 @@ func (pa *packageActions) Tool(name string) *toolActions {
 
 // Actions that can be done on a Tool
 
-// toolActions defines what actions can be performed on the specific Tool
+// ToolActions defines what actions can be performed on the specific Tool
 // It serves as a status container for the fluent APIs
-type toolActions struct {
+type ToolActions struct {
 	tool         *cores.Tool
 	forwardError error
 }
 
 // Get returns the final representation of the Tool
-func (ta *toolActions) Get() (*cores.Tool, error) {
+func (ta *ToolActions) Get() (*cores.Tool, error) {
 	err := ta.forwardError
 	if err == nil {
 		return ta.tool, nil
@@ -271,7 +271,7 @@ func (ta *toolActions) Get() (*cores.Tool, error) {
 }
 
 // IsInstalled checks whether any release of the Tool is installed in the system
-func (ta *toolActions) IsInstalled() (bool, error) {
+func (ta *ToolActions) IsInstalled() (bool, error) {
 	if ta.forwardError != nil {
 		return false, ta.forwardError
 	}
@@ -284,27 +284,27 @@ func (ta *toolActions) IsInstalled() (bool, error) {
 	return false, nil
 }
 
-func (ta *toolActions) Release(version *semver.RelaxedVersion) *toolReleaseActions {
+func (ta *ToolActions) Release(version *semver.RelaxedVersion) *ToolReleaseActions {
 	if ta.forwardError != nil {
-		return &toolReleaseActions{forwardError: ta.forwardError}
+		return &ToolReleaseActions{forwardError: ta.forwardError}
 	}
 	release := ta.tool.GetRelease(version)
 	if release == nil {
-		return &toolReleaseActions{forwardError: fmt.Errorf("release %s not found for tool %s", version, ta.tool.String())}
+		return &ToolReleaseActions{forwardError: fmt.Errorf("release %s not found for tool %s", version, ta.tool.String())}
 	}
-	return &toolReleaseActions{release: release}
+	return &ToolReleaseActions{release: release}
 }
 
 // END -- Actions that can be done on a Tool
 
-// toolReleaseActions defines what actions can be performed on the specific ToolRelease
+// ToolReleaseActions defines what actions can be performed on the specific ToolRelease
 // It serves as a status container for the fluent APIs
-type toolReleaseActions struct {
+type ToolReleaseActions struct {
 	release      *cores.ToolRelease
 	forwardError error
 }
 
-func (tr *toolReleaseActions) Get() (*cores.ToolRelease, error) {
+func (tr *ToolReleaseActions) Get() (*cores.ToolRelease, error) {
 	if tr.forwardError != nil {
 		return nil, tr.forwardError
 	}

arduino/cores/status.go

@@ -113,11 +113,11 @@ func (targetPackage *Package) String() string {
 func (tdep ToolDependency) extractTool(sc Packages) (*Tool, error) {
 	pkg, exists := sc.Packages[tdep.ToolPackager]
 	if !exists {
-		return nil, errors.New("Package not found")
+		return nil, errors.New("package not found")
 	}
 	tool, exists := pkg.Tools[tdep.ToolName]
 	if !exists {
-		return nil, errors.New("Tool not found")
+		return nil, errors.New("tool not found")
 	}
 	return tool, nil
 }
@@ -129,7 +129,7 @@ func (tdep ToolDependency) extractRelease(sc Packages) (*ToolRelease, error) {
 	}
 	release, exists := tool.Releases[tdep.ToolVersion.String()]
 	if !exists {
-		return nil, errors.New("Release Not Found")
+		return nil, errors.New("release Not Found")
 	}
 	return release, nil
 }
@@ -143,15 +143,15 @@ func (packages *Packages) GetDepsOfPlatformRelease(release *PlatformRelease) ([]
 	for _, dep := range release.Dependencies {
 		pkg, exists := packages.Packages[dep.ToolPackager]
 		if !exists {
-			return nil, fmt.Errorf("Package %s not found", dep.ToolPackager)
+			return nil, fmt.Errorf("package %s not found", dep.ToolPackager)
 		}
 		tool, exists := pkg.Tools[dep.ToolName]
 		if !exists {
-			return nil, fmt.Errorf("Tool %s not found", dep.ToolName)
+			return nil, fmt.Errorf("tool %s not found", dep.ToolName)
 		}
 		toolRelease, exists := tool.Releases[dep.ToolVersion.String()]
 		if !exists {
-			return nil, fmt.Errorf("Tool version %s not found", dep.ToolVersion)
+			return nil, fmt.Errorf("tool version %s not found", dep.ToolVersion)
 		}
 		ret = append(ret, toolRelease)
 	}

arduino/cores/tools.go

@@ -81,11 +81,12 @@ func (tool *Tool) GetAllReleasesVersions() []*semver.RelaxedVersion {
 
 // LatestRelease obtains latest version of a core package.
 func (tool *Tool) LatestRelease() *ToolRelease {
-	if latest := tool.latestReleaseVersion(); latest == nil {
+	latest := tool.latestReleaseVersion()
+	if latest == nil {
 		return nil
-	} else {
-		return tool.GetRelease(latest)
 	}
+
+	return tool.GetRelease(latest)
 }
 
 // latestReleaseVersion obtains latest version number.

arduino/resources/helpers.go

@@ -41,12 +41,12 @@ func (r *DownloadResource) IsCached(downloadDir *paths.Path) (bool, error) {
 	if err != nil {
 		return false, fmt.Errorf("getting archive path: %s", err)
 	}
-
-	if exist, err := archivePath.Exist(); err != nil {
+	exist, err := archivePath.Exist()
+	if err != nil {
 		return false, fmt.Errorf("checking archive existence: %s", err)
-	} else {
-		return exist, nil
 	}
+
+	return exist, nil
 }
 
 // Download a DownloadResource.

arduino/resources/install.go

@@ -96,11 +96,11 @@ func (release *DownloadResource) Install(downloadDir, tempPath, destDir *paths.P
 
 // IsDirEmpty returns true if the directory specified by path is empty.
 func IsDirEmpty(path *paths.Path) (bool, error) {
-	if files, err := path.ReadDir(); err != nil {
+	files, err := path.ReadDir()
+	if err != nil {
 		return false, err
-	} else {
-		return len(files) == 0, nil
 	}
+	return len(files) == 0, nil
 }
 
 func findPackageRoot(parent *paths.Path) (*paths.Path, error) {

builder_client_helpers/alive.go

@@ -15,7 +15,7 @@
  * a commercial license, send an email to license@arduino.cc.
  */
 
-package builderClient
+package builderclient
 
 import (
 	"context"

builder_client_helpers/boards.go

@@ -15,7 +15,7 @@
  * a commercial license, send an email to license@arduino.cc.
  */
 
-package builderClient
+package builderclient
 
 import (
 	"context"

builder_client_helpers/boards_v2.go

@@ -15,7 +15,7 @@
  * a commercial license, send an email to license@arduino.cc.
  */
 
-package builderClient
+package builderclient
 
 import (
 	"context"

builder_client_helpers/client.go

@@ -15,7 +15,7 @@
  * a commercial license, send an email to license@arduino.cc.
  */
 
-package builderClient
+package builderclient
 
 import (
 	"github.com/goadesign/goa"

builder_client_helpers/compilations.go

@@ -15,7 +15,7 @@
  * a commercial license, send an email to license@arduino.cc.
  */
 
-package builderClient
+package builderclient
 
 import (
 	"bytes"