Fixed all the problem reported by ineffassign ( ineffectual assignment)

Author: Mattia Bertorello

.golangci.yml

@@ -25,7 +25,6 @@ linters:
   - goconst
   - gocyclo
   - govet
-  - ineffassign
   - interfacer
   - lll
   - maligned

commands/commands_test.go

@@ -206,8 +206,10 @@ func TestUserLibs(t *testing.T) {
 func TestLibDownloadAndInstall(t *testing.T) {
 	defer makeTempDataDir(t)()
 	defer makeTempSketchbookDir(t)()
+	var d []byte
+	var exitCode int
 
-	exitCode, d := executeWithArgs(t, "core", "update-index")
+	exitCode, _ = executeWithArgs(t, "core", "update-index")
 	require.Zero(t, exitCode, "exit code")
 
 	// Download inexistent

commands/compile/compile.go

@@ -106,7 +106,7 @@ func run(cmd *cobra.Command, args []string) {
 
 	// Check for ctags tool
 	loadBuiltinCtagsMetadata(pm)
-	ctags, err := getBuiltinCtagsTool(pm)
+	ctags, _ := getBuiltinCtagsTool(pm)
 	if !ctags.IsInstalled() {
 		formatter.Print("Downloading and installing missing tool: " + ctags.String())
 		core.DownloadToolRelease(pm, ctags)
@@ -116,7 +116,7 @@ func run(cmd *cobra.Command, args []string) {
 			formatter.PrintError(err, "Could not load hardware packages.")
 			os.Exit(commands.ErrCoreConfig)
 		}
-		ctags, err = getBuiltinCtagsTool(pm)
+		ctags, _ = getBuiltinCtagsTool(pm)
 		if !ctags.IsInstalled() {
 			formatter.PrintErrorMessage("Missing ctags tool.")
 			os.Exit(commands.ErrCoreConfig)