Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Ferada/cl-inotify
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: datagraph/cl-inotify
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 6 commits
  • 1 file changed
  • 2 contributors

Commits on Mar 10, 2022

  1. change order: replace-p is supposed to replace the current mask not t… 

    …o add to it

from man 7 notify on IN_MASK_ADD:
add (OR) the events in mask to the watch mask (instead of replacing the mask)
    Max-Gerd Retzlaff authored and root committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    cd8e640 View commit details
    Browse the repository at this point in the history

  2. existing flags are actually at third position of the hash not cdr 

    This led to the error:
The value of SYMBOL is (:MASK-ADD :MOVE-SELF), which is not of type SYMBOL.
    Max-Gerd Retzlaff authored and root committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    13379a6 View commit details
    Browse the repository at this point in the history

  3. reimplement SANE-USER-FLAGS: if we use UNION already we do not need I… 

    …N_MASK_ADD at all

The existing code used :MASK-ADD when REPLACE-P was T,
which would not replace but OR the flags. So this part
was inverted.

Nevertheless, if there was a watch already configured the
code would always UNION with the previous flags, so that
flags would never be replaced.
    Max-Gerd Retzlaff authored and root committed Mar 10, 2022
    Configuration menu
    Copy the full SHA
    91b4dff View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2022

  1. use inotify-event-wd instead of slot-value

    root committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    3fe6d42 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into past

    root committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    2944f73 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into past

    root committed Mar 11, 2022
    Configuration menu
    Copy the full SHA
    9f492e1 View commit details
    Browse the repository at this point in the history
Loading