Skip to content

Restructure test files and Eslint improvements #594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 1, 2025
Merged

Restructure test files and Eslint improvements #594

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
55ba338
Restructure project files
EhabY Sep 22, 2025
edbf80f
Rebase fallout + minor eslint improvements
EhabY Sep 25, 2025
df363e3
Add better eslint rules for importing
EhabY Sep 25, 2025
dfed63a
Improve .vscodeignore
EhabY Sep 25, 2025
79e14d7
Move files around
EhabY Sep 25, 2025
ce8d2b3
Add service container and improve import/order
EhabY Sep 25, 2025
2c584be
Make it impossible to import test files in src
EhabY Sep 26, 2025
20b52be
Fix sorting of type imports
EhabY Sep 30, 2025
b326904
Put tests in the right folders
EhabY Oct 1, 2025
7745e13
Fix fixture path resolution and removed the @test alias
EhabY Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix sorting of type imports
  • Loading branch information
@EhabY
EhabY committed Oct 1, 2025
commit 20b52bea2ce39c746b792e70f403192e46ccc67e
3 changes: 2 additions & 1 deletion .eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@
],
"pathGroupsExcludedImportTypes": ["builtin", "external"],
"newlines-between": "always",
"alphabetize": { "order": "asc", "caseInsensitive": true }
"alphabetize": { "order": "asc", "caseInsensitive": true },
"sortTypesGroup": true
}
],
// Prevent duplicates and prefer merging into a single import
Expand Down
7 changes: 4 additions & 3 deletions src/inbox.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
import * as vscode from "vscode";

import type { CoderApi } from "./api/coderApi";
import type { Logger } from "./logging/logger";
import type { OneWayWebSocket } from "./websocket/oneWayWebSocket";
import type {
Workspace,
GetInboxNotificationResponse,
} from "coder/site/src/api/typesGenerated";

import type { CoderApi } from "./api/coderApi";
import type { Logger } from "./logging/logger";
import type { OneWayWebSocket } from "./websocket/oneWayWebSocket";

// These are the template IDs of our notifications.
// Maybe in the future we should avoid hardcoding
// these in both coderd and here.
Expand Down