-
Notifications
You must be signed in to change notification settings - Fork 35
Closed
Description
During download of the binary on the server (in linux via install.sh, untested on other platforms), the download is made directly to the destination file which may result in an incomplete download being left behind.
Lines 50 to 52 in 98276d9
| curl -sSL "$INSTALL_URL" -o $INSTALL_DIR/code-server | |
| elif command_exists wget; then | |
| wget -qO $INSTALL_DIR/code-server "$INSTALL_URL" |
Recommendations:
- Download to a temp file in the same dir (such as
.filename.temp1234and then move the file to the destination once the download succeeds. - Check the checksum of the downloaded file with the server. We have SHA1 checksums serverside (idk if we expose them as a file in the bin dir but we could start doing that).
Metadata
Metadata
Assignees
Labels
No labels