Skip to content

impl: prefer agent name over agent id in URI handler #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fioan89 merged 4 commits into from
Oct 1, 2025
+358 −161
Merged

impl: prefer agent name over agent id in URI handler #585

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b54b74a
impl: prefer agent name over agent id in URI handler
fioan89 Sep 30, 2025
4f9923c
impl: prefer agent name over agent id in URI handler (2)
fioan89 Oct 1, 2025
ec68c50
chore: update and fix UTs
fioan89 Oct 1, 2025
5f0e363
chore: refactor UTs related to agent matching in URI handling
fioan89 Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update and fix UTs 
Test cases related to agent matching have to be updated
now that agent name is preferred over agent id.
  • Loading branch information
@fioan89
fioan89 committed Oct 1, 2025
commit ec68c5010f6e5eff32f6ee5789c5edde4568ed6e
43 changes: 32 additions & 11 deletions src/test/kotlin/com/coder/gateway/util/LinkHandlerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,24 @@ internal class LinkHandlerTest {
val tests =
listOf(
Pair(mapOf("agent" to "agent_name"), "9a920eee-47fb-4571-9501-e4b3120c12f2"),
Pair(mapOf("agent_id" to "9a920eee-47fb-4571-9501-e4b3120c12f2"), "9a920eee-47fb-4571-9501-e4b3120c12f2"),
Pair(
mapOf("agent_id" to "9a920eee-47fb-4571-9501-e4b3120c12f2"),
"9a920eee-47fb-4571-9501-e4b3120c12f2"
),
Pair(mapOf("agent" to "agent_name_2"), "fb3daea4-da6b-424d-84c7-36b90574cfef"),
Pair(mapOf("agent_id" to "fb3daea4-da6b-424d-84c7-36b90574cfef"), "fb3daea4-da6b-424d-84c7-36b90574cfef"),
Pair(
mapOf("agent_id" to "fb3daea4-da6b-424d-84c7-36b90574cfef"),
"fb3daea4-da6b-424d-84c7-36b90574cfef"
),
Pair(mapOf("agent" to "agent_name_3"), "b0e4c54d-9ba9-4413-8512-11ca1e826a24"),
Pair(mapOf("agent_id" to "b0e4c54d-9ba9-4413-8512-11ca1e826a24"), "b0e4c54d-9ba9-4413-8512-11ca1e826a24"),
// Prefer agent_id.
Pair(
mapOf("agent_id" to "b0e4c54d-9ba9-4413-8512-11ca1e826a24"),
"b0e4c54d-9ba9-4413-8512-11ca1e826a24"
),
// Prefer agent name.
Pair(
mapOf(
"agent" to "agent_name",
"agent" to "agent_name_3",
"agent_id" to "b0e4c54d-9ba9-4413-8512-11ca1e826a24",
),
"b0e4c54d-9ba9-4413-8512-11ca1e826a24",
Expand All @@ -89,15 +98,19 @@ internal class LinkHandlerTest {
Triple(mapOf("agent" to "ws.agent_name"), IllegalArgumentException::class, "agent named"),
Triple(mapOf("agent" to "agent_name_4"), IllegalArgumentException::class, "agent named"),
Triple(mapOf("agent_id" to "not-a-uuid"), IllegalArgumentException::class, "agent with ID"),
Triple(mapOf("agent_id" to "ceaa7bcf-1612-45d7-b484-2e0da9349168"), IllegalArgumentException::class, "agent with ID"),
// Will ignore agent if agent_id is set even if agent matches.
Triple(
mapOf("agent_id" to "ceaa7bcf-1612-45d7-b484-2e0da9349168"),
IllegalArgumentException::class,
"agent with ID"
),
// Will ignore agent_id if agent is set even if agent_id matches.
Triple(
mapOf(
"agent" to "agent_name",
"agent" to "unknown_agent_name",
"agent_id" to "ceaa7bcf-1612-45d7-b484-2e0da9349168",
),
IllegalArgumentException::class,
"agent with ID",
"The workspace \"ws\" does not have an agent named \"unknown_agent_name\"",
),
)

Expand Down Expand Up @@ -142,7 +155,11 @@ internal class LinkHandlerTest {
Triple(mapOf("agent" to "ws"), IllegalArgumentException::class, "agent named"),
Triple(mapOf("agent" to "ws.agent_name_3"), IllegalArgumentException::class, "agent named"),
Triple(mapOf("agent" to "agent_name_4"), IllegalArgumentException::class, "agent named"),
Triple(mapOf("agent_id" to "ceaa7bcf-1612-45d7-b484-2e0da9349168"), IllegalArgumentException::class, "agent with ID"),
Triple(
mapOf("agent_id" to "ceaa7bcf-1612-45d7-b484-2e0da9349168"),
IllegalArgumentException::class,
"agent with ID"
),
)

tests.forEach {
Expand All @@ -166,7 +183,11 @@ internal class LinkHandlerTest {
Triple(mapOf("agent" to null), IllegalArgumentException::class, "has no agents"),
Triple(mapOf("agent_id" to null), IllegalArgumentException::class, "has no agents"),
Triple(mapOf("agent" to "agent_name"), IllegalArgumentException::class, "has no agents"),
Triple(mapOf("agent_id" to "9a920eee-47fb-4571-9501-e4b3120c12f2"), IllegalArgumentException::class, "has no agents"),
Triple(
mapOf("agent_id" to "9a920eee-47fb-4571-9501-e4b3120c12f2"),
IllegalArgumentException::class,
"has no agents"
),
)

tests.forEach {
Expand Down
Loading