Refactor wizard steps #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
code-asher
force-pushed
the
asher/refactor-steps
branch
from
c6437c8 to
05c2106
Compare
Contributor
Qodana Community for JVM45 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.3.0
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
The main goal was the ability to use steps separately. We may only need the IDE selection step when handling a link, for example. Each step now takes a specific type of data (if it needs some) then returns a specific type of data. The way to tell if a step is ready to return data is via a callback you pass into the step. I think more improvements will become apparent once we start using it in the link handler.
This was deleted a while back but I did not update the plugin.xml.
Otherwise they will not surface to the user (as an error bubble at the bottom).
code-asher
force-pushed
the
asher/refactor-steps
branch
from
05c2106 to
6af9950
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to make it so we can jump straight into the IDE selection step from the link handler, since we will not need the first step.
Part 1 of #317