Fix duplicate holidays, add locale support to parse_date, achieve 100% coverage #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…00% coverage - Fix duplicate holidays bug: convert Iterable[date] to set to handle duplicates correctly - Support generators in holiday parameters: workdays_between, add_business_days, is_business_day - Add dayfirst parameter to parse_date for locale-aware date parsing (US vs European style) - Document format precedence: US-style (M/D/Y) by default, European-style (D/M/Y) with dayfirst=True - Add 8 new tests for generator inputs, duplicate holidays, dayfirst parsing, and generator edge cases - Achieve 100% code coverage (118 tests passing) Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
dayfirstparameter to parse_date for US vs European date format preferenceTesting