Skip to content

Allow /api/v1/health bypass auth default #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhouzhuojie merged 1 commit into from
Oct 12, 2020
Merged

Allow /api/v1/health bypass auth default #407

zhouzhuojie merged 1 commit into from
Oct 12, 2020

Conversation

@zhouzhuojie
Copy link
Collaborator

@zhouzhuojie zhouzhuojie commented Oct 6, 2020

Description

Make /api/v1/health bypass the auth default so that systems like k8s can do healthz check easily.

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@zhouzhuojie zhouzhuojie mentioned this pull request Oct 6, 2020
Merged
@zhouzhuojie zhouzhuojie merged commit daccd2e into master Oct 12, 2020
@zhouzhuojie zhouzhuojie deleted the zz/add-allow-health-default branch October 12, 2020 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@zhouzhuojie