Add xcresult converter from deploy step#315
Draft
gergely-sallai wants to merge 12 commits intomasterfrom
Draft
Conversation
- Moved over XCResult converters from steps-deploy-to-bitrise - Bumped dependency versions
Added mandatory docs for exported functions and variables. Did not check for the validity of exports, though.
gergely-sallai
force-pushed
the
step-2230-move-testreport-to-steputils
branch
2 times, most recently
from
84c1042 to
5a3fd2b
Compare
Missing test artifacts.
gergely-sallai
force-pushed
the
step-2230-move-testreport-to-steputils
branch
from
5a3fd2b to
e3453b9
Compare
- Removed the added bitrise.yml config that prepared the test environment, because that way `go test` would heavily depend on bitrise ci config. - Moved test data preparation logic to test_converter
This test was failing when it is run on a machine that has different timezone than UTC. The reason is that we were using xcrun xcresulttool to extract attachments from xcresult and that assembles filenames on the fly using local TZ, this made the test prone to failures (false negative) because it explicitly verified for UTC times. I don't think we need to test xcresult, so refactored this part.
gergely-sallai
force-pushed
the
step-2230-move-testreport-to-steputils
branch
from
ccca158 to
e5f1a14
Compare
ofalvai
reviewed
Mar 11, 2026
| ) | ||
|
|
||
| // TestSummaryPlist ... | ||
| type TestSummaryPlist struct { |
Contributor
There was a problem hiding this comment.
Can this type (and its methods) be private to the package? I might be wrong, but I only see it used in Convert().
Contributor
There was a problem hiding this comment.
And once these are private, we no longer need to write doc comments :)
Note: had to rename some variable to not be confused with private types now. This also true for `func Parse(....)` -> `func loadXCResultData(....)` it was clashing with converter.go's `parse()`
# Conflicts: # go.mod # go.sum
This has to stay exported, was too eager to remove its doc.
ofalvai
previously approved these changes
Mar 12, 2026
Reasons: - This was no-op for most of our converters - The parameter (the reason the func was introduced in the first place I assume) is closely tied to xcresult3 conversion, which is a close implementation detail, not something that belongs in a general interface.
It was causing test failures in deploy-to-bitrise-io step during plist parsing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat: STEP-2230 Add xcresult converter from deploy step