Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: @aws-cdk/toolkit-lib@v1.2.1
Choose a base ref
...
head repository: aws/aws-cdk-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: @aws-cdk/toolkit-lib@v1.2.2
Choose a head ref
  • 7 commits
  • 50 files changed
  • 8 contributors

Commits on Jun 27, 2025

  1. fix(cdk-assets): docker-credential-cdk-assets cannot be invoked as …

    …a program (#661)
    
    Ever since #603, the file
    references an external package that is not installed during installation
    of `cdk-assets`. This causes:
    
    ```console
    Error: Cannot find module '@aws-cdk/cdk-assets-lib'
    Require stack:
    - /usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js
    - /usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets
        at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15)
        at Module._load (node:internal/modules/cjs/loader:981:27)
        at Module.require (node:internal/modules/cjs/loader:1231:19)
        at require (node:internal/modules/helpers:177:18)
        at Object.<anonymous> (/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js:16:26)
        at Module._compile (node:internal/modules/cjs/loader:1364:14)
        at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
        at Module.load (node:internal/modules/cjs/loader:1203:32)
        at Module._load (node:internal/modules/cjs/loader:1019:12)
        at Module.require (node:internal/modules/cjs/loader:1231:19) {
      code: 'MODULE_NOT_FOUND',
      requireStack: [
        '/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js',
        '/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets'
      ]
    }
    ```
    
    To fix, lets bundle this script as well (in addition to the standard
    `cdk-assets` entrypoint).
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    iliapolo and github-actions authored Jun 27, 2025
    Configuration menu
    Copy the full SHA
    98b12f9 View commit details
    Browse the repository at this point in the history
  2. fix: unstable=toolkit-lib-engine has no effect (#668)

    The `engine` field is not being passed on when passing the call to the
    worker pool.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 27, 2025
    Configuration menu
    Copy the full SHA
    4a8441e View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2025

  1. chore(deps): upgrade dependencies (#669)

    Upgrades project dependencies. See details in [workflow run].
    
    [Workflow Run]:
    https://github.com/aws/aws-cdk-cli/actions/runs/15961035860
    
    ------
    
    *Automatically created by projen via the "upgrade" workflow*
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
    3 people authored Jun 30, 2025
    Configuration menu
    Copy the full SHA
    3f83d2c View commit details
    Browse the repository at this point in the history
  2. fix(cli-integ): CI=true test fails when jsii prints to stderr (#672)

    JSII doesn't respect the `CI=true` behavior (nor should it), prints to
    `stderr`, then the test fails.
    
    Silence another source of jsii stderr output.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 30, 2025
    Configuration menu
    Copy the full SHA
    e8fe1c9 View commit details
    Browse the repository at this point in the history
  3. chore: ensure correct major version for some more packages (#670)

    Definitely keeping the following additional packages on the current
    major version:
    
    ```
    @aws-cdk/cli-plugin-contract
    @aws-cdk/cloudformation-diff
    @aws-cdk/integ-runner
    ```
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    mrgrain authored Jun 30, 2025
    Configuration menu
    Copy the full SHA
    628b04c View commit details
    Browse the repository at this point in the history
  4. fix(integ-runner): integ-runner produces snapshot that doesn't valida…

    …te (#666)
    
    The integ-runner uses `synthFast` to produce the assembly that will be
    used to compare the snapshot to, to determine if there is "a change".
    
    However, when a snapshot has changed and a test is run, there is a fork:
    
    - In dry-run mode: `synthFast` will be used to produce the updated
    snapshot.
    - In real-mode, the result of `this.deploy()` will be the updated
    snapshot (but also: the next time it will be compared to the result of
    `synthFast`).
    
    We are running into a situation where the results of `synthFast` and
    `this.deploy` are different, and snapshot validation fails.
    
    In this change, we always generate the snapshot using `synthFast`, and
    ignore the template produced by `this.deploy()`. This makes sure that
    the templates will at least compile equal.
    
    I'm not sure why this ever worked this way, because the template that is
    deployed can be specialized to an account and region, but the snapshot
    can never be, so we need to investigate a little more.
    
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    rix0rrr authored Jun 30, 2025
    Configuration menu
    Copy the full SHA
    7cac5d2 View commit details
    Browse the repository at this point in the history

Commits on Jul 1, 2025

  1. feat(cli): telemetry opt-out command (#579)

    Fixes #575 
    
    Enables users of the CDK CLI to opt out of CDK CLI telemetry collection.
    More details in the [RFC](aws/aws-cdk-rfcs#734).
    
    Telemetry will be enabled by default.
    
    The following command will disable it, local to your CDK App:
    `cdk cli-telemetry --disable`
    
    The following command will enable it again:
    `cdk cli-telemetry --enable`
    
    To globally enable/disable telemetry add `{ "cli-telemetry": false }` to
    the context values of your `~/.cdk.json` file.
    
    > At the time of writing this PR - the CDK CLI still does not yet send
    any telemetry data. We are providing the opt-out capability now to give
    enough time to opt-out in advance if they so choose.
    
    ---
    By submitting this pull request, I confirm that my contribution is made
    under the terms of the Apache-2.0 license
    
    ---------
    
    Signed-off-by: github-actions <github-actions@github.com>
    Co-authored-by: github-actions <github-actions@github.com>
    Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com>
    Co-authored-by: Kaizen Conroy <zen.conroy@gmail.com>
    4 people authored Jul 1, 2025
    Configuration menu
    Copy the full SHA
    3b4d18e View commit details
    Browse the repository at this point in the history
Loading