-
Notifications
You must be signed in to change notification settings - Fork 40
Comparing changes
Open a pull request
base repository: aws/aws-cdk-cli
base: @aws-cdk/toolkit-lib@v1.2.1
head repository: aws/aws-cdk-cli
compare: @aws-cdk/toolkit-lib@v1.2.2
- 7 commits
- 50 files changed
- 8 contributors
Commits on Jun 27, 2025
-
fix(cdk-assets):
docker-credential-cdk-assets
cannot be invoked as ……a program (#661) Ever since #603, the file references an external package that is not installed during installation of `cdk-assets`. This causes: ```console Error: Cannot find module '@aws-cdk/cdk-assets-lib' Require stack: - /usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js - /usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets at Module._resolveFilename (node:internal/modules/cjs/loader:1140:15) at Module._load (node:internal/modules/cjs/loader:981:27) at Module.require (node:internal/modules/cjs/loader:1231:19) at require (node:internal/modules/helpers:177:18) at Object.<anonymous> (/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js:16:26) at Module._compile (node:internal/modules/cjs/loader:1364:14) at Module._extensions..js (node:internal/modules/cjs/loader:1422:10) at Module.load (node:internal/modules/cjs/loader:1203:32) at Module._load (node:internal/modules/cjs/loader:1019:12) at Module.require (node:internal/modules/cjs/loader:1231:19) { code: 'MODULE_NOT_FOUND', requireStack: [ '/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets.js', '/usr/local/lib/node_modules/cdk-assets/bin/docker-credential-cdk-assets' ] } ``` To fix, lets bundle this script as well (in addition to the standard `cdk-assets` entrypoint). --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <github-actions@github.com> Co-authored-by: github-actions <github-actions@github.com>
Configuration menu - View commit details
-
Copy full SHA for 98b12f9 - Browse repository at this point
Copy the full SHA 98b12f9View commit details -
fix: unstable=toolkit-lib-engine has no effect (#668)
The `engine` field is not being passed on when passing the call to the worker pool. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 4a8441e - Browse repository at this point
Copy the full SHA 4a8441eView commit details
Commits on Jun 30, 2025
-
chore(deps): upgrade dependencies (#669)
Upgrades project dependencies. See details in [workflow run]. [Workflow Run]: https://github.com/aws/aws-cdk-cli/actions/runs/15961035860 ------ *Automatically created by projen via the "upgrade" workflow* --------- Signed-off-by: github-actions <github-actions@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Rico Huijbers <rix0rrr@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3f83d2c - Browse repository at this point
Copy the full SHA 3f83d2cView commit details -
fix(cli-integ): CI=true test fails when jsii prints to stderr (#672)
JSII doesn't respect the `CI=true` behavior (nor should it), prints to `stderr`, then the test fails. Silence another source of jsii stderr output. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for e8fe1c9 - Browse repository at this point
Copy the full SHA e8fe1c9View commit details -
chore: ensure correct major version for some more packages (#670)
Definitely keeping the following additional packages on the current major version: ``` @aws-cdk/cli-plugin-contract @aws-cdk/cloudformation-diff @aws-cdk/integ-runner ``` --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 628b04c - Browse repository at this point
Copy the full SHA 628b04cView commit details -
fix(integ-runner): integ-runner produces snapshot that doesn't valida…
…te (#666) The integ-runner uses `synthFast` to produce the assembly that will be used to compare the snapshot to, to determine if there is "a change". However, when a snapshot has changed and a test is run, there is a fork: - In dry-run mode: `synthFast` will be used to produce the updated snapshot. - In real-mode, the result of `this.deploy()` will be the updated snapshot (but also: the next time it will be compared to the result of `synthFast`). We are running into a situation where the results of `synthFast` and `this.deploy` are different, and snapshot validation fails. In this change, we always generate the snapshot using `synthFast`, and ignore the template produced by `this.deploy()`. This makes sure that the templates will at least compile equal. I'm not sure why this ever worked this way, because the template that is deployed can be specialized to an account and region, but the snapshot can never be, so we need to investigate a little more. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
Configuration menu - View commit details
-
Copy full SHA for 7cac5d2 - Browse repository at this point
Copy the full SHA 7cac5d2View commit details
Commits on Jul 1, 2025
-
feat(cli): telemetry opt-out command (#579)
Fixes #575 Enables users of the CDK CLI to opt out of CDK CLI telemetry collection. More details in the [RFC](aws/aws-cdk-rfcs#734). Telemetry will be enabled by default. The following command will disable it, local to your CDK App: `cdk cli-telemetry --disable` The following command will enable it again: `cdk cli-telemetry --enable` To globally enable/disable telemetry add `{ "cli-telemetry": false }` to the context values of your `~/.cdk.json` file. > At the time of writing this PR - the CDK CLI still does not yet send any telemetry data. We are providing the opt-out capability now to give enough time to opt-out in advance if they so choose. --- By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license --------- Signed-off-by: github-actions <github-actions@github.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Kaizen Conroy <36202692+kaizencc@users.noreply.github.com> Co-authored-by: Kaizen Conroy <zen.conroy@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 3b4d18e - Browse repository at this point
Copy the full SHA 3b4d18eView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff @aws-cdk/toolkit-lib@v1.2.1...@aws-cdk/toolkit-lib@v1.2.2