feat(kafka): lazily deserialize key/value/headers #4068
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
This PR refactors the way keys, values, and headers are deserialized and parsed so that they are processed lazily when the customer accesses them, and not eagerly before they're passed to the AWS Lambda handler.
This approach allows customers to write code like the one below, and introduce custom error handling for different types of errors:
On a more technical note, the lazy processing relies on custom
get
ter functions for objects. This allows us to run custom logic just in time when the customer accesses a property.The downside of this approach is that these
get
functions can only be synchronous. This is not an issue when it comes to deserializing since all these operations are synchronous, however since we were dynamically importing some of the deserializers to avoid introducing extra deps for customers I had to do a significant refactor in the logic that chooses and loads the deserializers to load the extra modules asynchronously in closures while staying sync.As part of the refactor I also improved the error handling to make it consistent and added some unit test cases.
Issue number: closes #4067
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.