Skip to content

Commit dab0be1

Browse files
authored
refactor(kafka): improve tests & error handling (#4262)
1 parent 081a514 commit dab0be1

File tree

2 files changed

+8
-4
lines changed

2 files changed

+8
-4
lines changed

packages/kafka/src/deserializer/protobuf.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ const deserialize = <T>(
4040
}
4141
} catch (error) {
4242
throw new KafkaConsumerDeserializationError(
43-
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${messageType}`
43+
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${JSON.stringify(messageType)}`
4444
);
4545
}
4646

@@ -64,7 +64,7 @@ const deserialize = <T>(
6464
return decoded;
6565
} catch {
6666
throw new KafkaConsumerDeserializationError(
67-
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${messageType}`
67+
`Failed to deserialize Protobuf message: ${error}, message: ${data}, messageType: ${JSON.stringify(messageType)}`
6868
);
6969
}
7070
}

packages/kafka/tests/unit/consumer.test.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -141,13 +141,15 @@ describe('Kafka consumer', () => {
141141
// Prepare
142142
const handler = kafkaConsumer(
143143
async (event) => {
144+
const results = [];
144145
for (const record of event.records) {
145146
try {
146-
return record.value;
147+
results.push(record.value);
147148
} catch (error) {
148149
return error;
149150
}
150151
}
152+
return results;
151153
},
152154
{
153155
// @ts-expect-error - testing missing schemaStr
@@ -241,14 +243,16 @@ describe('Kafka consumer', () => {
241243
// Prepare
242244
const handler = kafkaConsumer(
243245
async (event) => {
246+
const results = [];
244247
for (const record of event.records) {
245248
try {
246249
const { value, key } = record;
247-
return [value, key];
250+
results.push([value, key]);
248251
} catch (error) {
249252
return error;
250253
}
251254
}
255+
return results;
252256
},
253257
{
254258
value: {

0 commit comments

Comments
 (0)