Skip to content

Commit 1f3befa

Browse files
svozzadreamorosi
andauthored
Apply suggestions from code review
Co-authored-by: Andrea Amorosi <dreamorosi@gmail.com>
1 parent 177db6a commit 1f3befa

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

packages/event-handler/tests/unit/rest/RouteHandlerRegistry.test.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import { RouteHandlerRegistry } from '../../../src/rest/RouteHandlerRegistry.js'
55
import type { Path } from '../../../src/types/rest.js';
66

77
describe('Class: RouteHandlerRegistry', () => {
8-
it('should warn when registering a duplicate route', () => {
8+
it('warns when registering a duplicate route', () => {
99
// Prepare
1010
const mockLogger = {
1111
debug: vi.fn(),
@@ -47,7 +47,7 @@ describe('Class: RouteHandlerRegistry', () => {
4747
description: 'consecutive parameters without separator',
4848
},
4949
])(
50-
'should not register routes with invalid path pattern: $description',
50+
'shouldn\'t register routes with invalid path pattern: $description',
5151
({ path }) => {
5252
// Prepare
5353
const mockLogger = {
@@ -74,7 +74,7 @@ describe('Class: RouteHandlerRegistry', () => {
7474
}
7575
);
7676

77-
it('should not register routes with duplicate parameter names', () => {
77+
it('doesn\'t register routes with duplicate parameter names', () => {
7878
// Prepare
7979
const mockLogger = {
8080
debug: vi.fn(),
@@ -211,7 +211,7 @@ describe('Class: RouteHandlerRegistry', () => {
211211
registry.register(route2);
212212
registry.register(route3);
213213

214-
// Assert
214+
// Assess
215215
const allRoutes = registry.getAllRoutes();
216216
expect(allRoutes).toHaveLength(3);
217217
expect(allRoutes).toContain(route1);

0 commit comments

Comments
 (0)