fix(batch): report multiple failures #967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/L
heitorlessa
added a commit
that referenced
this pull request
Jan 20, 2022
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(batch): report multiple failures (#967) docs(tutorial): fix path to images (#963) Update documentation mistake (#961)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: 966
Description of changes:
Dictionary/List comprehensions can only contain one unique dict key (last one wins), as expected. Our logic for reporting multiple failures had a bug where we were constructing multiple dictionaries of
{"itemIdentifier": message}instead of appending to a list - you can't solve this with a dictionary/list comprehension as the key is always static.Thanks to @kimberlyamandalu for spotting this critical bug, since our tests somehow were only testing for a single fail record hence why we didn't spot it earlier (nor during review)
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.