fix(event-sources): Pass authorizer data to APIGatewayEventAuthorizer #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: - contract APIGatewayEventAuthorizer from the authorizer data - add test cases for the additional fields that can optional be in the authorizer dict - Update DictWrapper to allow for a default in `get`
pull-request-size
bot
added
the
size/M
heitorlessa
suggested changes
Dec 14, 2021
Codecov Report
@@ Coverage Diff @@
## develop #897 +/- ##
========================================
Coverage 99.88% 99.88%
========================================
Files 118 118
Lines 5133 5133
Branches 573 573
========================================
Hits 5127 5127
Misses 2 2
Partials 4 4
Continue to review full report at Codecov.
|
heitorlessa
approved these changes
Dec 16, 2021
| @@ -56,7 +67,7 @@ def route_key(self) -> Optional[str]: | |||
|
|
|||
| @property | |||
| def authorizer(self) -> APIGatewayEventAuthorizer: | |||
| return APIGatewayEventAuthorizer(self._data) | |||
| return APIGatewayEventAuthorizer(self._data["requestContext"]["authorizer"]) | |||
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Dec 17, 2021
…tools-python into feat/batch-new-processor * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: fix(parser): kinesis sequence number is str, not int (aws-powertools#907) feat(apigateway): add exception_handler support (aws-powertools#898) fix(event-sources): Pass authorizer data to APIGatewayEventAuthorizer (aws-powertools#897) chore(deps): bump fastjsonschema from 2.15.1 to 2.15.2 (aws-powertools#891)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Changes:
getChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.