fix(apigateway): allow list of HTTP methods in route method #838
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r ApiGatewayResolver
pull-request-size
bot
added
the
size/M
pull-request-size
bot
removed
the
size/M
boring-cyborg
bot
added
the
documentation
pull-request-size
bot
added
the
size/L
| for item in methods: | ||
| self._routes[(rule, item, cors, compress, cache_control)] = func | ||
| # Convert methods to tuple. It needs to be hashable as its part of the self._routes dict key | ||
| methods = (method,) if isinstance(method, str) else tuple(method) |
heitorlessa
changed the title
heitorlessa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #837
Description of changes:
Allow a list (or tuple) of methods to be passed to the
ApiGatewayResolver.routemethod, to match the functionality inRouter.routeChecklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.