fix(feature-flags): rules should evaluate with an AND op #724
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pull-request-size
bot
added
the
size/S
6 tasks
|
The test i changed was working because the match value of the rule was the same as the default value of the feature. |
heitorlessa
approved these changes
Oct 3, 2021
|
Thank you and specially @gwlester for catching it |
heitorlessa
changed the title
heitorlessa
added a commit
to heitorlessa/aws-lambda-powertools-python
that referenced
this pull request
Oct 5, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: feat(feature_flags): Added inequality conditions (aws-powertools#721) fix(feature-flags): rules should evaluate with an AND op (aws-powertools#724) fix(logger): push extra keys to the end (aws-powertools#722)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.