docs(bedrock): fix BedrockServiceRole in template.yaml #6436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly. Signed-off-by: Guido Nebiolo <GuidoNebiolo@users.noreply.github.com>
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
pull-request-size
bot
added
the
size/XS
1 task
leandrodamascena
assigned
leandrodamascena and
GuidoNebiolo and unassigned
leandrodamascena
leandrodamascena
changed the title
|
leandrodamascena
approved these changes
Apr 10, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #6436 +/- ##
========================================
Coverage 96.33% 96.33%
========================================
Files 243 243
Lines 11763 11763
Branches 871 871
========================================
Hits 11332 11332
Misses 337 337
Partials 94 94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience! |
leandrodamascena
added a commit
that referenced
this pull request
Apr 24, 2025
Fix BedrockServiceRole in template.yaml Fixing indentation of AssumeRolePolicyDocument content in BedrockServiceRole that prevent the template to be deployed correctly. Signed-off-by: Guido Nebiolo <GuidoNebiolo@users.noreply.github.com> Co-authored-by: Leandro Damascena <lcdama@amazon.pt>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: #6438
Summary
Changes
Fixing indentation of
AssumeRolePolicyDocumentcontent inBedrockServiceRolein template.yaml that prevent the SAM template to be deployed correctly.User experience
N/A
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.