Skip to content

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 22, 2021

Issue #, if available: #638

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 22, 2021
@boring-cyborg boring-cyborg bot added the tests label Aug 22, 2021
@heitorlessa heitorlessa added the bug Something isn't working label Aug 22, 2021
@heitorlessa heitorlessa force-pushed the fix/idempotency-hash-order branch from c702532 to 96cbdc1 Compare August 22, 2021 06:45
@pull-request-size pull-request-size bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #639 (96cbdc1) into develop (27e3930) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #639   +/-   ##
========================================
  Coverage    99.97%   99.97%           
========================================
  Files          116      116           
  Lines         4846     4846           
  Branches       265      265           
========================================
  Hits          4845     4845           
  Partials         1        1           
Impacted Files Coverage Δ
...wertools/utilities/idempotency/persistence/base.py 99.36% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27e3930...96cbdc1. Read the comment docs.

@heitorlessa heitorlessa merged commit ba52721 into aws-powertools:develop Aug 22, 2021
@heitorlessa heitorlessa deleted the fix/idempotency-hash-order branch August 22, 2021 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants