Skip to content

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 16, 2021

Issue #, if available:

Description of changes:

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 16, 2021
@boring-cyborg boring-cyborg bot added area/utilities dependencies Pull requests that update a dependency file tests labels Aug 16, 2021
@heitorlessa heitorlessa added this to the 1.20.0 milestone Aug 16, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #613 (d05c973) into develop (173297f) will decrease coverage by 0.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #613      +/-   ##
===========================================
- Coverage    99.95%   99.69%   -0.27%     
===========================================
  Files          113      114       +1     
  Lines         4535     4555      +20     
  Branches       246      249       +3     
===========================================
+ Hits          4533     4541       +8     
- Misses           0        7       +7     
- Partials         2        7       +5     
Impacted Files Coverage Δ
aws_lambda_powertools/shared/jmespath_utils.py 100.00% <100.00%> (ø)
...da_powertools/utilities/feature_flags/appconfig.py 100.00% <100.00%> (ø)
...mbda_powertools/utilities/validation/exceptions.py 100.00% <100.00%> (ø)
...ambda_powertools/utilities/validation/validator.py 100.00% <100.00%> (ø)
aws_lambda_powertools/utilities/parser/types.py 71.42% <0.00%> (-28.58%) ⬇️
...wertools/utilities/idempotency/persistence/base.py 92.99% <0.00%> (-6.37%) ⬇️
aws_lambda_powertools/logging/logger.py 100.00% <0.00%> (ø)
aws_lambda_powertools/tracing/tracer.py 100.00% <0.00%> (ø)
aws_lambda_powertools/metrics/metrics.py 100.00% <0.00%> (ø)
aws_lambda_powertools/logging/formatter.py 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 173297f...d05c973. Read the comment docs.

@heitorlessa heitorlessa changed the title chore(shared): fix cyclic import & refactor jmespath data extraction fn chore(shared): fix cyclic import & refactor data extraction fn Aug 16, 2021
@heitorlessa heitorlessa merged commit 8930915 into aws-powertools:develop Aug 16, 2021
@heitorlessa heitorlessa deleted the chore/fix-cyclic-import branch August 16, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants