Skip to content

Conversation

ran-isenberg
Copy link
Contributor

@ran-isenberg ran-isenberg commented Aug 5, 2021

Issue #, if available:

Description of changes:

Schema changes of condition keywords.

  • Add IN action instead of contains
  • Add NOT_IN action

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 5, 2021
@boring-cyborg boring-cyborg bot added the tests label Aug 5, 2021
@ran-isenberg ran-isenberg changed the title feat (feature flags): Add not_in action and rename contains to in feat(feature flags): Add not_in action and rename contains to in Aug 5, 2021
@ran-isenberg
Copy link
Contributor Author

@heitorlessa there ya go

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2021

Codecov Report

Merging #589 (8b8b8b3) into develop (4eb4aaa) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #589   +/-   ##
========================================
  Coverage    99.95%   99.95%           
========================================
  Files          113      113           
  Lines         4533     4534    +1     
  Branches       245      245           
========================================
+ Hits          4531     4532    +1     
  Partials         2        2           
Impacted Files Coverage Δ
...owertools/utilities/feature_flags/feature_flags.py 100.00% <100.00%> (ø)
...ambda_powertools/utilities/feature_flags/schema.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb4aaa...8b8b8b3. Read the comment docs.

@heitorlessa heitorlessa added this to the 1.19.0 milestone Aug 5, 2021
@heitorlessa heitorlessa added the feature New feature or functionality label Aug 5, 2021
@am29d am29d requested a review from heitorlessa August 10, 2021 05:21
@heitorlessa heitorlessa merged commit 6952d83 into aws-powertools:develop Aug 10, 2021
@heitorlessa heitorlessa changed the title feat(feature flags): Add not_in action and rename contains to in feat(feature-flags): Add not_in action and rename contains to in Aug 10, 2021
@sthulb sthulb added the feature_flags Feature Flags utility label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature_flags Feature Flags utility feature New feature or functionality size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants