Skip to content

Conversation

anafalcao
Copy link
Contributor

Issue number:
#5559

Summary

Changes

Please provide a summary of what's being changed

The eventSource for self-managed Apache Kafka is not "eventSource": "aws:SelfManagedKafka" as we are currently using. It should be "eventSource": "SelfManagedKafka" as documented in the oficial Developer Guide https://docs.aws.amazon.com/lambda/latest/dg/with-kafka.html

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@anafalcao anafalcao requested a review from a team November 18, 2024 21:40
@boring-cyborg boring-cyborg bot added the tests label Nov 18, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2024
@anafalcao anafalcao marked this pull request as draft November 18, 2024 21:42
@anafalcao anafalcao changed the title remove the aws: from the SelfManagedKafka - WIP remove aws from the SelfManagedKafka event - WIP Nov 18, 2024
@anafalcao anafalcao changed the title remove aws from the SelfManagedKafka event - WIP fix(event): remove 'aws:' prefix from SelfManagedKafka event source - WIP Nov 18, 2024
Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.16%. Comparing base (5f64029) to head (e55880d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #5584   +/-   ##
========================================
  Coverage    96.16%   96.16%           
========================================
  Files          229      229           
  Lines        10836    10836           
  Branches      2015     2015           
========================================
  Hits         10420    10420           
  Misses         327      327           
  Partials        89       89           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@github-actions github-actions bot added the bug Something isn't working label Nov 18, 2024
@anafalcao anafalcao changed the title fix(event): remove 'aws:' prefix from SelfManagedKafka event source - WIP fix(event): remove 'aws:' prefix from SelfManagedKafka event source Nov 19, 2024
@anafalcao anafalcao marked this pull request as ready for review November 19, 2024 12:09
@anafalcao anafalcao changed the title fix(event): remove 'aws:' prefix from SelfManagedKafka event source fix(data_class): remove 'aws:' prefix from SelfManagedKafka event source Nov 19, 2024
@anafalcao anafalcao changed the title fix(data_class): remove 'aws:' prefix from SelfManagedKafka event source fix(parser): remove 'aws:' prefix from SelfManagedKafka event source Nov 19, 2024
@anafalcao anafalcao changed the title fix(parser): remove 'aws:' prefix from SelfManagedKafka event source fix(parser): remove 'aws:' prefix from SelfManagedKafka model Nov 19, 2024
@anafalcao anafalcao linked an issue Nov 19, 2024 that may be closed by this pull request
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for sending this PR @anafalcao! Great work!! 🚀

APPROVED!

Copy link

@anafalcao anafalcao merged commit 150623b into aws-powertools:develop Nov 19, 2024
12 checks passed
@anafalcao anafalcao self-assigned this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: KafkaSelfManagedEventModel eventSource not correct
2 participants