Skip to content

Conversation

leandrodamascena
Copy link
Contributor

Issue number: #4639

Summary

Change in CDK that impacts ca-west-1: aws/aws-cdk#30108

Changes

This PR downgrades AWS CDK-related dependencies to 2.145.0 - last known working version for us - so that we can continue the release process for our packages.

I have verified that both aws-cdk and aws-cdk-lib are no longer present in our dependency tree by running npm ls , below the results:

npm ls aws-cdk-lib                                                                
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ @aws-lambda-powertools/testing-utils@2.3.0 -> ./packages/testing
│ └── aws-cdk-lib@2.145.0
├─┬ layers@2.3.0 -> ./layers
│ └── aws-cdk-lib@2.145.0
└─┬ powertools-sample-app@2.3.0 -> ./examples/app
  └── aws-cdk-lib@2.145.0


~/Codes/aws-lambda-powertools-typescript chore/downgrade_cdk*
❯ npm ls aws-cdk              
aws-lambda-powertools-typescript@0.0.1 /Users/aamorosi/Codes/aws-lambda-powertools-typescript
├─┬ layers@2.3.0 -> ./layers
│ └── aws-cdk@2.145.0
└─┬ powertools-sample-app@2.3.0 -> ./examples/app
  └── aws-cdk@2.145.0

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@leandrodamascena leandrodamascena requested a review from a team June 27, 2024 12:16
@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Jun 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 27, 2024
@github-actions github-actions bot added the internal Maintenance changes label Jun 27, 2024
Copy link

codecov bot commented Jun 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.45%. Comparing base (e14e768) to head (1766220).
Report is 661 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4640      +/-   ##
===========================================
+ Coverage    96.38%   96.45%   +0.07%     
===========================================
  Files          214      223       +9     
  Lines        10030    10723     +693     
  Branches      1846     1995     +149     
===========================================
+ Hits          9667    10343     +676     
- Misses         259      268       +9     
- Partials       104      112       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leandrodamascena leandrodamascena merged commit 8cda231 into aws-powertools:develop Jun 27, 2024
@leandrodamascena leandrodamascena deleted the cdk/downgrade branch June 27, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Maintenance changes size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants