Skip to content

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Mar 7, 2024

Issue number: #3902

Summary

Changes

Please provide a summary of what's being changed

This PR fixes a bug when validating POST bodies in BedrockAgentResolver.

User experience

Please share what the user experience looks like before and after this change

After this PR, it's now possible to use @app.post decorators with BedrockAgents.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@rubenfonseca rubenfonseca requested a review from a team March 7, 2024 15:02
@boring-cyborg boring-cyborg bot added the tests label Mar 7, 2024
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 7, 2024
@rubenfonseca rubenfonseca linked an issue Mar 7, 2024 that may be closed by this pull request
@github-actions github-actions bot added the bug Something isn't working label Mar 7, 2024
Copy link

sonarqubecloud bot commented Mar 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rubenfonseca rubenfonseca merged commit e79eef4 into develop Mar 8, 2024
@rubenfonseca rubenfonseca deleted the rf/3902 branch March 8, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Validating POST body fails with BedrockAgentResolver
2 participants