Skip to content

fix(event_handler): make invalid chars a raw str to fix invalid escape sequence #2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 21, 2023
Merged

fix(event_handler): make invalid chars a raw str to fix invalid escape sequence #2982

merged 2 commits into from
Aug 21, 2023

Conversation

rubenfonseca
Copy link
Contributor

@rubenfonseca rubenfonseca commented Aug 21, 2023 •
edited
Loading

Issue number: #2980

Summary

This PR fixes a syntax error on the API Gateway project.

Changes

Please provide a summary of what's being changed

Removes the noqa: W605 and make the string a raw string.

User experience

Please share what the user experience looks like before and after this change

After this PR, the code should not print a warning when importing the APIGateway resolver.

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 21, 2023
@github-actions github-actions bot added the bug Something isn't working label Aug 21, 2023
@boring-cyborg boring-cyborg bot added the tests label Aug 21, 2023
@rubenfonseca rubenfonseca marked this pull request as ready for review August 21, 2023 09:52
@rubenfonseca rubenfonseca requested a review from a team August 21, 2023 09:52
@rubenfonseca rubenfonseca linked an issue Aug 21, 2023 that may be closed by this pull request
Bug: API Gateway - invalid escape sequence '\[' #2980
Closed
@rubenfonseca rubenfonseca self-assigned this Aug 21, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@heitorlessa heitorlessa changed the title fix(event_handler): fix invalid escape sequence fix(event_handler): make invalid chars a raw str to fix invalid escape sequence Aug 21, 2023
@heitorlessa heitorlessa merged commit 2a8be25 into develop Aug 21, 2023
@heitorlessa heitorlessa deleted the rf/api-gateway-escape-sequence branch August 21, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@heitorlessa heitorlessa heitorlessa approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rubenfonseca rubenfonseca

Labels
bug Something isn't working event_handlers size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: API Gateway - invalid escape sequence '\['
2 participants
@rubenfonseca @heitorlessa