Skip to content

fix: prevent touching preconfigured loggers #249 #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 21, 2020
Merged

fix: prevent touching preconfigured loggers #249 #250

merged 3 commits into from
Dec 21, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Dec 21, 2020 •
edited
Loading

Issue #, if available: #249

Description of changes:

  • Adds init attribute to parent Loggers to verify whether they've been previously configured
  • Updates tests to ensure all service_name is unique
  • Ensures there is only one test that doesn't define service_name

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added bug Something isn't working area/logger labels Dec 21, 2020
@heitorlessa heitorlessa changed the title bugfix: prevent touching preconfigured loggers #249 fix: prevent touching preconfigured loggers #249 Dec 21, 2020
@heitorlessa heitorlessa merged commit bdb3925 into aws-powertools:develop Dec 21, 2020
@heitorlessa heitorlessa deleted the fix/#249 branch December 21, 2020 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@dnlopes dnlopes dnlopes approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heitorlessa @dnlopes