Skip to content

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Oct 19, 2022

Issue number: #1459

Summary

Changes

Please provide a summary of what's being changed

Remove warning and deprecate POWERTOOLS_EVENT_HANDLER_DEBUG in favour of POWERTOOLS_DEV before launching V2.

User experience

Please share what the user experience looks like before and after this change

Replaced older env var with POWERTOOLS_DEV in docs too, and note about future deprecation.

image

image

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.


View rendered docs/index.md

@heitorlessa heitorlessa requested a review from a team as a code owner October 19, 2022 16:30
@heitorlessa heitorlessa requested review from rubenfonseca and removed request for a team October 19, 2022 16:30
@boring-cyborg boring-cyborg bot added area/commons documentation Improvements or additions to documentation tests labels Oct 19, 2022
@pull-request-size pull-request-size bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 19, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 99.40% // Head: 99.36% // Decreases project coverage by -0.03% ⚠️

Coverage data is based on head (a8fe423) compared to base (2864b46).
Patch coverage: 95.55% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1620      +/-   ##
==========================================
- Coverage   99.40%   99.36%   -0.04%     
==========================================
  Files         127      127              
  Lines        5842     5808      -34     
  Branches      367      369       +2     
==========================================
- Hits         5807     5771      -36     
- Misses         17       18       +1     
- Partials       18       19       +1     
Impacted Files Coverage Δ
aws_lambda_powertools/shared/constants.py 100.00% <ø> (ø)
aws_lambda_powertools/utilities/batch/base.py 97.79% <ø> (ø)
...s/utilities/data_classes/dynamo_db_stream_event.py 98.13% <95.45%> (-1.87%) ⬇️
aws_lambda_powertools/event_handler/api_gateway.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@leandrodamascena
Copy link
Contributor

The fastest PR on all github 🚀
image

@leandrodamascena leandrodamascena requested review from leandrodamascena and removed request for rubenfonseca October 19, 2022 16:34
@leandrodamascena leandrodamascena self-assigned this Oct 19, 2022
@leandrodamascena leandrodamascena merged commit feca650 into aws-powertools:v2 Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants