Skip to content

fix: regression 104 and revert docstring #106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2020
Merged

fix: regression 104 and revert docstring #106

merged 2 commits into from
Aug 14, 2020

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 14, 2020 •
edited
Loading

Issue #, if available: #104

Description of changes:

  • Revert docstring to str as env var values cannot be int
  • Add tests to confirm that's always the case, and propagates Unknown log level error up

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa self-assigned this Aug 14, 2020
@heitorlessa heitorlessa merged commit 24a3bdf into aws-powertools:develop Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@heitorlessa heitorlessa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heitorlessa