Skip to content

Conversation

michaelbrewer
Copy link
Contributor

@michaelbrewer michaelbrewer commented Feb 10, 2022

Issue #, if available:

Description of changes:

Changes:

  • Fix import statements for CORSConfig and Response in docs (for current versions)
  • Add CORSConfig to init.py for ease of use (to allow for this shortcut in future versions)

Checklist

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Changes:
- Fix import statement in docs
- Add CORSConfig to __init__.py for ease of use
@boring-cyborg boring-cyborg bot added area/event_handlers documentation Improvements or additions to documentation labels Feb 10, 2022
@github-actions github-actions bot added the bug Something isn't working label Feb 10, 2022
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 10, 2022

Codecov Report

Merging #1019 (5ae2d4e) into develop (00b5b5c) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1019   +/-   ##
========================================
  Coverage    99.96%   99.96%           
========================================
  Files          119      119           
  Lines         5365     5365           
  Branches       612      612           
========================================
  Hits          5363     5363           
  Partials         2        2           
Impacted Files Coverage Δ
aws_lambda_powertools/event_handler/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00b5b5c...5ae2d4e. Read the comment docs.

@michaelbrewer
Copy link
Contributor Author

@heitorlessa - don’t forget about the doc fix

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michaelbrewer!!!

@heitorlessa heitorlessa changed the title fix(event_handler): fix docs for import of CORSConfig and Response fix(event_handler): add CORSConfig high level import, fix docs import snippet Feb 21, 2022
@heitorlessa heitorlessa changed the title fix(event_handler): add CORSConfig high level import, fix docs import snippet fix(event_handler): CORSConfig high level import; fix docs import snippets Feb 21, 2022
@heitorlessa heitorlessa changed the title fix(event_handler): CORSConfig high level import; fix docs import snippets fix(event_handler): docs snippets, high-level import CorsConfig Feb 21, 2022
@heitorlessa heitorlessa merged commit 82835ae into aws-powertools:develop Feb 21, 2022
@heitorlessa heitorlessa deleted the fix-1018 branch February 21, 2022 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants