HID: Remove empty HID_::begin() method to simplify

forderud · forderud · commit ea656f115107 · 2024-09-16T16:57:17.000+02:00
This method doesn't do anything, so I'm proposing to remove it to make the class easier to understand for new developers.
diff --git a/libraries/HID/src/HID.cpp b/libraries/HID/src/HID.cpp
@@ -154,9 +154,4 @@ HID_::HID_(void) : PluggableUSBModule(1, 1, epType),
 	PluggableUSB().plug(this);
 }
 
-int HID_::begin(void)
-{
-	return 0;
-}
-
 #endif /* if defined(USBCON) */
diff --git a/libraries/HID/src/HID.h b/libraries/HID/src/HID.h
@@ -92,7 +92,6 @@ class HID_ : public PluggableUSBModule
 {
 public:
   HID_(void);
-  int begin(void);
   int SendReport(uint8_t id, const void* data, int len);
   void AppendDescriptor(HIDSubDescriptor* node);
 

Original file line number	Diff line number	Diff line change
`@@ -154,9 +154,4 @@ HID_::HID_(void) : PluggableUSBModule(1, 1, epType),`
`154`	`154`	`PluggableUSB().plug(this);`
`155`	`155`	`}`
`156`	`156`
`157`		`-int HID_::begin(void)`
`158`		`-{`
`159`		`- return 0;`
`160`		`-}`
`161`		`-`
`162`	`157`	`#endif /* if defined(USBCON) */`
Original file line number	Diff line number	Diff line change
`@@ -92,7 +92,6 @@ class HID_ : public PluggableUSBModule`
`92`	`92`	`{`
`93`	`93`	`public:`
`94`	`94`	`HID_(void);`
`95`		`- int begin(void);`
`96`	`95`	`int SendReport(uint8_t id, const void* data, int len);`
`97`	`96`	`void AppendDescriptor(HIDSubDescriptor* node);`
`98`	`97`