Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: apache/curator
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: apache-curator-5.9.0
Choose a base ref
...
head repository: apache/curator
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
  • 4 commits
  • 21 files changed
  • 2 contributors

Commits on Jul 4, 2025

  1. Configuration menu
    Copy the full SHA
    2829144 View commit details
    Browse the repository at this point in the history

Commits on Aug 19, 2025

  1. Enforce string values in InstanceSpec's custom properties (#1274)

    `InstanceSpec`'s `customProperties` will be fed to `Properties` in
    `QuorumConfigBuilder::buildConfigProperties`, so we have to make sure it
    contains only string values.
    
    Instead of `ClassCastException` in read phase, this pr complains in
    `InstanceSpec` construction phase.
    
    We could deprecate these constructors in next step by introducing builder
    for `InstanceSpec`(#1222).
    
    Fixes #1178, CURATOR-663.
    kezhuw authored Aug 19, 2025
    Configuration menu
    Copy the full SHA
    0b549b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2025

  1. Add builder to construct InstanceSpec (#1275)

    It is hard for us to know what does
    `new InstanceSpec(null, -1, -1, -1, true, -1, -1, -1)` means now.
    
    Closes #1222.
    kezhuw authored Aug 27, 2025
    Configuration menu
    Copy the full SHA
    3bc3ea1 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2025

  1. GH-1277: SafeNotifyService threads leak in CuratorFrameWorkImpl (#1278)

    CURATOR-495 introduced a new runSafeService field in CuratorFrameworkImpl class, and this field is
    either initialized by an external ExecutorService via the builder, or it is created internally
    within the class.
    
    In the CuratorFrameworkImpl#close method though, this Executor is never closed, so the threads
    that are opened by the instances are lingering there until the VM is closed by default.
    Worse, if someone specifies a thread factory to the framework implementation via the builder that
    produces non-daemon threads, the VM never exits due to the unstopped single thread executor.
    
    Fixes #1277.
    fapifta authored Dec 18, 2025
    Configuration menu
    Copy the full SHA
    f18f0ac View commit details
    Browse the repository at this point in the history
Loading