CB-13813: (iOS) Remove old iOS code#381
Merged
jcesarmobile merged 1 commit intoapache:masterfrom Dec 4, 2018
Merged
Conversation
shazron
approved these changes
Dec 4, 2018
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
iOS
What does this PR do?
It removes iOS 8 checks as cordova-ios only support iOS 9 and newer. (might still be breaking change as won't work on iOS 7?)
Removed the deprecated UIAlertView
Reworked the logic about requesting/checking permissions so it doesn't present the camera picker if the permission is not granted. As side effect of this, also fixes CB-14082, which had another PR that won't be needed
What testing has been done on this change?
Checklist