CB-14047: (android) Camera Plugin code cleanup - Part #1#319
Merged
macdonst merged 1 commit intoapache:masterfrom Apr 22, 2018
Merged
CB-14047: (android) Camera Plugin code cleanup - Part #1#319macdonst merged 1 commit intoapache:masterfrom
macdonst merged 1 commit intoapache:masterfrom
Conversation
…s with final variables
Member
|
Thanks @hazems |
Member
Author
|
My pleasure @macdonst |
hazems
changed the title
hazems
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
What does this PR do?
Replacing Repeated String literals with final variables in CameraLauncher for having better maintainability and easier changes.
What testing has been done on this change?
Making sure that everything builds fine, also, run my own tests for Android Camera and all pass fine.
Checklist
Notices
I'm an old Apache Committer and a PMC member for another Apache project, so no worry about my CLA since I submitted it already.