Merged
Conversation
Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.
|
I am using this plugin as well and would appreciate this change. |
Member
|
Not sure why there are massive npm errors. Close and reopen this PR to poke Travis to run it again. |
Contributor
Author
|
Ok, just closed and reopened! |
Member
|
Still stuck. Will close and re-open again, sigh |
Member
|
Lol, now Appveyor passes but Travis has one build in its matrix that does not (looks to be a too many accesses error, needs an npm update). Since the previous build Travis passed, but AppVeyor failed, I'll treat this as a CI quirk |
Contributor
|
Shaz, I believe you should be able to restart Travis jobs one by one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.
Platforms affected
What does this PR do?
What testing has been done on this change?
Checklist