Fix warnings for caption render#1222
Merged
majapw merged 2 commits intoreact-dates:masterfrom Jun 22, 2018
Merged
Conversation
ljharb
approved these changes
Jun 21, 2018
ljharb
force-pushed
the
fix-warnings-for-caption-render
branch
3 times, most recently
from
0eb39c0 to
9c43e4c
Compare
Added "onMonthChange", "onYearChange" propTypes in order to hide warnings
ljharb
force-pushed
the
fix-warnings-for-caption-render
branch
from
9c43e4c to
113310b
Compare
majapw
force-pushed
the
fix-warnings-for-caption-render
branch
from
113310b to
6f45c76
Compare
majapw
approved these changes
Jun 22, 2018
Collaborator
majapw
left a comment
majapw
left a comment
There was a problem hiding this comment.
I think this should pass tests now! :)
majapw
force-pushed
the
fix-warnings-for-caption-render
branch
from
6f45c76 to
431b8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have fixed a warning about last PR, and also updated the Readme.md fixing a typo. No difficult and no new tests / functionality.