Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: prometheus/client_ruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: ahyield/client_ruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 9 commits
  • 11 files changed
  • 1 contributor

Commits on Sep 3, 2019

  1. Add failing tests for integrating in rack 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    d4f4e32 View commit details
    Browse the repository at this point in the history

  2. Fix failing registry_spec when running individually 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    be2ac37 View commit details
    Browse the repository at this point in the history

  3. Fix initial metrics errors from the collector 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 3, 2019
    Configuration menu
    Copy the full SHA
    fb4504e View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2019

  1. Merge pull request #1 from ahmgeek/test/broken-integration 

    Test/broken integration
    @ahyield
    ahyield authored Sep 4, 2019
    Configuration menu
    Copy the full SHA
    3963c87 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2019

  1. Fix thread safeness issues 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 5, 2019
    Configuration menu
    Copy the full SHA
    80adc30 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #2 from ahmgeek/test/broken-integration 

    Fix thread safeness issues
    @ahyield
    ahyield authored Sep 5, 2019
    Configuration menu
    Copy the full SHA
    677df41 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2019

  1. Adape the thread safe specs to cover the registry usage 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    f7cfbb4 View commit details
    Browse the repository at this point in the history

  2. Use registry as singleton object 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 11, 2019
    Configuration menu
    Copy the full SHA
    ef27cf2 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2019

  1. Refactor the integrations specs 

    Signed-off-by: Ahmad Tolba <tolpa1@gmail.com>
    @ahyield
    ahyield committed Sep 18, 2019
    Configuration menu
    Copy the full SHA
    367638a View commit details
    Browse the repository at this point in the history
Loading