Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: rubocop/ruby-style-guide
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: agworld/ruby-style-guide
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 7 commits
  • 1 file changed
  • 3 contributors

Commits on Nov 22, 2019

  1. Specify underscore prefix for private methods.

    Jack Casey committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    280c3f2 View commit details
    Browse the repository at this point in the history

  2. Prefer 120 character line length limit

    Jack Casey committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    2900b61 View commit details
    Browse the repository at this point in the history

  3. Add comments and examples RE dangerous mutation.

    Jack Casey committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    eacccec View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2019

  1. Be specific which variations we use for some ambiguous rules.

    Jack Casey committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    d5ad000 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #4 from agworld/feature/specific_variations 

    Be specific which variations we use for some ambiguous rules.
    Jack Casey authored Nov 25, 2019
    Configuration menu
    Copy the full SHA
    1abd825 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. Update style guide to double-quotes by default 

    c.f:
https://github.com/agworld/org-web/pull/15
https://rubystyle.guide/#consistent-string-literals-double-quote
    @stwr667
    stwr667 committed Aug 24, 2020
    Configuration menu
    Copy the full SHA
    5306fae View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2020

  1. Merge pull request #5 from agworld/change_to_double_quotes 

    Update style guide to double-quotes by default
    @stwr667
    stwr667 authored Aug 27, 2020
    Configuration menu
    Copy the full SHA
    b2dc64d View commit details
    Browse the repository at this point in the history
Loading