Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: data-integrations/wrangler
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: develop
Choose a base ref
...
head repository: aditheking/wrangler
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: develop
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 3 commits
  • 16 files changed
  • 1 contributor

Commits on Apr 14, 2025

  1. Add BYTE_SIZE and TIME_DURATION token types to parser 

    - Updated pom.xml to include a skip option for checkstyle.
- Enhanced TokenType enum to include BYTE_SIZE and TIME_DURATION.
- Modified Directives.g4 to recognize BYTE_SIZE and TIME_DURATION in value parsing.
- Updated RecipeVisitor to handle new token types in recipe parsing.
- Added tests to ensure correct parsing of new unit types in GrammarBasedParserTest and RecipeCompilerTest.
    @aditheking
    aditheking committed Apr 14, 2025
    Configuration menu
    Copy the full SHA
    6fa6547 View commit details
    Browse the repository at this point in the history

  2. Refactor ByteSize and TimeDuration classes for improved parsing and r… 

    …epresentation

- Updated ByteSize and TimeDuration classes to enhance parsing logic and error handling.
- Changed original value storage from double to String for better accuracy.
- Improved regex patterns for parsing byte sizes and time durations.
- Updated JSON serialization to return original string representation.
- Added comprehensive unit tests for parsing, conversion, and equality checks.
- Enhanced RecipeVisitor to handle exceptions during parsing of new token types.
- Updated AggregateStats directive to work with ByteSize and TimeDuration objects directly.
    @aditheking
    aditheking committed Apr 14, 2025
    Configuration menu
    Copy the full SHA
    86aadcb View commit details
    Browse the repository at this point in the history

  3. Add support for BYTE_SIZE and TIME_DURATION in AggregateStats directive 

    - Introduced new argument types for parsing byte sizes and time durations in the AggregateStats directive.
- Updated README.md to document new argument types and usage examples.
- Enhanced AggregateStats class to calculate total or average statistics based on specified output units.
- Improved error handling for invalid types and null values during aggregation.
- Added comprehensive tests for new functionality, including optional arguments for output units and average calculations.
    @aditheking
    aditheking committed Apr 14, 2025
    Configuration menu
    Copy the full SHA
    3af8268 View commit details
    Browse the repository at this point in the history
Loading