🐛 FIX: Some fixes

Author: omkarnathparida

Project-Euler/Problem021.js

@@ -13,7 +13,7 @@
  * @param {Number} maxNum
  * @returns {Number} Sum of all amicable numbers under maxNum
  */
-export const sumAmicableNum = (maxNum) => {
+export const sumAmicableNums = (maxNum) => {
   const amicNums = []
 
   for (let i = 1; i < maxNum; i++) {
@@ -23,23 +23,13 @@ export const sumAmicableNum = (maxNum) => {
       amicNums.push(i, left)
     }
   }
-  return amicNums.reduce((a, b) => {
-    a += b
-    return a
-  })
+  return amicNums.reduce((a, b) => a + b, 0)
 }
 
 const d = (num) => {
   const output = []
   for (let i = 1; i < num; i++) {
-    if (!(num % i)) { output.push(i) }
-  }
-  if (!output.length) {
-    return 0
-  } else {
-    return output.reduce((a, b) => {
-      a += b
-      return a
-    })
+    if (num % i === 0) { output.push(i) }
   }
+  return output.reduce((a, b) => a + b, 0)
 }

Project-Euler/test/Problem021.test.js

@@ -1,8 +1,8 @@
-import { sumAmicableNum } from '../Problem021.js'
+import { sumAmicableNums } from '../Problem021.js'
 
 describe('Amicable numbers', () => {
   // Project Euler Condition Check
-  test('if the number is 10000', () => {
-    expect(sumAmicableNum(10000)).toBe(31626)
+  test('if the limit is 10000', () => {
+    expect(sumAmicableNums(10000)).toBe(31626)
   })
 })