Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aeron-io/simple-binary-encoding
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: SeanKim/simple-binary-encoding
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 4, 2023

  1. Fixed several issues: 

    #1: LibRsDef explicitly us crate:: to disambiguate from built in mods like bool
#2: Added acting_version field to Composite structs to fix compilation errors when using Composite structs.  This is an incomplete implementation because the parent doesn't pass the acting_version to the composite because you need to change the signature of wrap(parent, offset) to include the acting_version, so this version just ensures that if the acting_version isn't set on the composite, it disregards the version check.
#3: fixed primitiveArrayDecoder to return an empty array of the right size if less than version required.
    @adam-talos @SeanKim
    adam-talos authored and SeanKim committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    dee1fb5 View commit details
    Browse the repository at this point in the history

  2. lint: line length

    @SeanKim
    SeanKim committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    7093024 View commit details
    Browse the repository at this point in the history
Loading