feat: rename Row.get_value to Row.get_cell#947
Merged
lars-reimann merged 5 commits intomainfrom Nov 20, 2024
Merged
Conversation
lars-reimann
requested review from
Gerhardsa0,
Marsmaennchen221 and
sibre28
as code owners
Contributor
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports MegaLinter is graciously provided by |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #947 +/- ##
=======================================
Coverage 94.40% 94.40%
=======================================
Files 121 121
Lines 7468 7468
=======================================
Hits 7050 7050
Misses 418 418 ☔ View full report in Codecov by Sentry. |
lars-reimann
pushed a commit
that referenced
this pull request
Nov 26, 2024
## [0.29.0](v0.28.1...v0.29.0) (2024-11-26) ### Features * remove `Image.__array__` ([#964](#964)) ([d2f59c9](d2f59c9)) * rename `count_row_if` to `count_rows_if` ([#960](#960)) ([f5d6324](f5d6324)) * rename `epoch_size` to `epoch_count` ([#962](#962)) ([fa62e9b](fa62e9b)) * rename `flip_vertically` and `flip_horizontally` methods ([#946](#946)) ([a3607d7](a3607d7)), closes [#945](#945) * rename `load_pretrained_model` to `from_pretrained_model` ([#957](#957)) ([5b32acc](5b32acc)) * rename `Row.get_value` to `Row.get_cell` ([#947](#947)) ([e77cb6c](e77cb6c)) ### Bug Fixes * avoid performance warning when accessing `column_count` ([#949](#949)) ([c24b6d5](c24b6d5)) * handle deprecations in third-party libraries ([#963](#963)) ([e10e6bb](e10e6bb)) * index tensor on cpu ([#961](#961)) ([afafd43](afafd43))
Member
Author
|
🎉 This PR is included in version 0.29.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Rename
Row.get_valuetoRow.get_cellto avoid confusion withColumn.get_value. The row method returns a cell, while the column method returns an actual Python constant. The new name emphasizes this difference.