Skip to content

Commit fdf5251

Browse files
committed
Explicit lengths
This isn't related directly to the PR, but figured I'd tidy it up while I'm in here.
1 parent 5986d74 commit fdf5251

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

sp_BlitzWho.sql

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ SET @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
186186
COALESCE(r.open_transaction_count, blocked.open_tran) AS open_transaction_count ,
187187
qmg.dop AS degree_of_parallelism ,
188188
qmg.request_time ,
189-
COALESCE(CAST(qmg.grant_time AS VARCHAR), ''N/A'') AS grant_time ,
189+
COALESCE(CAST(qmg.grant_time AS VARCHAR(20)), ''N/A'') AS grant_time ,
190190
qmg.requested_memory_kb ,
191191
qmg.granted_memory_kb AS grant_memory_kb,
192192
CASE WHEN qmg.grant_time IS NULL THEN ''N/A''
@@ -200,16 +200,16 @@ SET @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
200200
qmg.is_small ,
201201
qmg.timeout_sec ,
202202
qmg.resource_semaphore_id ,
203-
COALESCE(CAST(qmg.wait_order AS VARCHAR), ''N/A'') AS wait_order ,
204-
COALESCE(CAST(qmg.wait_time_ms AS VARCHAR),
203+
COALESCE(CAST(qmg.wait_order AS VARCHAR(20)), ''N/A'') AS wait_order ,
204+
COALESCE(CAST(qmg.wait_time_ms AS VARCHAR(20)),
205205
''N/A'') AS wait_time_ms ,
206206
CASE qmg.is_next_candidate
207207
WHEN 0 THEN ''No''
208208
WHEN 1 THEN ''Yes''
209209
ELSE ''N/A''
210210
END AS next_candidate_for_memory_grant ,
211211
qrs.target_memory_kb ,
212-
COALESCE(CAST(qrs.max_target_memory_kb AS VARCHAR),
212+
COALESCE(CAST(qrs.max_target_memory_kb AS VARCHAR(20)),
213213
''Small Query Resource Semaphore'') AS max_target_memory_kb ,
214214
qrs.total_memory_kb ,
215215
qrs.available_memory_kb ,
@@ -218,7 +218,7 @@ SET @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
218218
qrs.grantee_count ,
219219
qrs.waiter_count ,
220220
qrs.timeout_error_count ,
221-
COALESCE(CAST(qrs.forced_grant_count AS VARCHAR),
221+
COALESCE(CAST(qrs.forced_grant_count AS VARCHAR(20)),
222222
''Small Query Resource Semaphore'') AS forced_grant_count,
223223
s.nt_domain ,
224224
s.host_name ,
@@ -398,7 +398,7 @@ SELECT @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
398398
COALESCE(r.open_transaction_count, blocked.open_tran) AS open_transaction_count ,
399399
qmg.dop AS degree_of_parallelism ,
400400
qmg.request_time ,
401-
COALESCE(CAST(qmg.grant_time AS VARCHAR), ''Memory Not Granted'') AS grant_time ,
401+
COALESCE(CAST(qmg.grant_time AS VARCHAR(20)), ''Memory Not Granted'') AS grant_time ,
402402
qmg.requested_memory_kb ,
403403
qmg.granted_memory_kb AS grant_memory_kb,
404404
CASE WHEN qmg.grant_time IS NULL THEN ''N/A''
@@ -412,16 +412,16 @@ SELECT @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
412412
qmg.is_small ,
413413
qmg.timeout_sec ,
414414
qmg.resource_semaphore_id ,
415-
COALESCE(CAST(qmg.wait_order AS VARCHAR), ''N/A'') AS wait_order ,
416-
COALESCE(CAST(qmg.wait_time_ms AS VARCHAR),
415+
COALESCE(CAST(qmg.wait_order AS VARCHAR(20)), ''N/A'') AS wait_order ,
416+
COALESCE(CAST(qmg.wait_time_ms AS VARCHAR(20)),
417417
''N/A'') AS wait_time_ms ,
418418
CASE qmg.is_next_candidate
419419
WHEN 0 THEN ''No''
420420
WHEN 1 THEN ''Yes''
421421
ELSE ''N/A''
422422
END AS next_candidate_for_memory_grant ,
423423
qrs.target_memory_kb ,
424-
COALESCE(CAST(qrs.max_target_memory_kb AS VARCHAR),
424+
COALESCE(CAST(qrs.max_target_memory_kb AS VARCHAR(20)),
425425
''Small Query Resource Semaphore'') AS max_target_memory_kb ,
426426
qrs.total_memory_kb ,
427427
qrs.available_memory_kb ,
@@ -430,7 +430,7 @@ SELECT @StringToExecute = N'SET TRANSACTION ISOLATION LEVEL READ UNCOMMITTED;
430430
qrs.grantee_count ,
431431
qrs.waiter_count ,
432432
qrs.timeout_error_count ,
433-
COALESCE(CAST(qrs.forced_grant_count AS VARCHAR),
433+
COALESCE(CAST(qrs.forced_grant_count AS VARCHAR(20)),
434434
''Small Query Resource Semaphore'') AS forced_grant_count,
435435
s.nt_domain ,
436436
s.host_name ,

0 commit comments

Comments
 (0)